gokermu
23 April 2022 10:57
1
Hey guys,
I created a blank new document, quickly added couple elements, and sent it to speckle. When I close this document without saving and try to quit Revit, this causes a fatal error and Revit crashes. Take a look at the recording:
teocomi
23 April 2022 12:43
2
I can repro too, should have been fixed but we need a better solution…
1 Like
teocomi
23 April 2022 19:43
3
I think I finally nailed it and made a new release as well: 2.5.2, let me know how it goes!
1 Like
teocomi
25 April 2022 16:13
5
Ok, it turns out it’s not our fault this time, we’ll wait for a fix in this UI framework we’re using and we’ll push a fix!
AvaloniaUI:master ← ltetak:feature/skia_crash_on_exit
opened 08:33AM - 28 Mar 22 UTC
## What does the pull request do?
It fixes the crash on any .net framework aval… onia application on exit.
## What is the current behavior?
Application crashes leaving log in the Event Viewer (on windows). It does not repro with .net core and might be depending on some other factors but it is easily reproducible. The impact is medium since it is on the exit but still can cause issues with the proper app shutdown.
## What is the updated/expected behavior with this PR?
Application should not crash on exit.
## How was the solution implemented (if it's not obvious)?
The problem is partially in the skiasharp pattern of disposing everything in the finalizer. Finalizer does not have well defined priority of invocations and thus the SKFont instance is finalized after a lock on which it is depending. A proper solution would be to dispose the SKFont instance but that would require a bigger architectural change. So I used a workaround (a proper solution is welcome of course).
## Breaking changes
This class is a singleton so it shouldn't create any memory leaks.
## Fixed issues
Fixes https://github.com/AvaloniaUI/Avalonia/issues/7579
1 Like