No families for Revit floors?

tlmn · 6 February 2023 15:59

Hey,

it looks like the family parameter for Revit floors has been straight up forgotten in the conversion?

specklesystems/speckle-sharp/blob/469016a77f3d261ee9d8482af79e5ee423d373f4/Objects/Converters/ConverterRevit/ConverterRevitShared/Partial Classes/ConvertFloor.cs#L126


      
                }
          #endif
          
          
      SetInstanceParameters(revitFloor, speckleFloor);
          
          
      appObj.Update(status: ApplicationObject.State.Created, createdId: revitFloor.UniqueId, convertedItem: revitFloor);
                appObj = SetHostedElements(speckleFloor, revitFloor, appObj);
                return appObj;
              }
          
          
    private RevitFloor FloorToSpeckle(DB.Floor revitFloor, out List<string> notes)
              {
                notes = new List<string>();
                var profiles = GetProfiles(revitFloor);
          
          
      var speckleFloor = new RevitFloor();
                speckleFloor.type = revitFloor.Document.GetElement(revitFloor.GetTypeId()).Name;
                speckleFloor.outline = profiles[0];
                if (profiles.Count > 1)
                {
                  speckleFloor.voids = profiles.Skip(1).ToList();

I had a look at a couple of my streams and it seems to always be null…

connor · 6 February 2023 16:58

Hey @tlmn,

Thank you for bringing this to our attention. You are absolutely correct that Speckle is not currently setting the “Family” property when sending floors from Revit to Speckle. I have fixed this issue (you can see the code changes here if you’d like) and you can expect to see this functionality when we release the connector version 2.12 which should be the end of this week or beginning of next week.

If you want the functionality sooner, we will be releasing a beta version of the release for testing on Wednesday this week.

Thanks again for helping us to improve Speckle