bmc
18 August 2023 16:01
1
Hi @jonathon
I believe I found my way in in PowerBI, however now, and looking through the Web Viewer I found out that some categories won’t have the ‘material quantities’ tree, which I am using to take off the area, volumes and the materialrefID.
For example the Wall (Curtain Wall - Family) and it’s components.
Would you know if this is not exported or should be found elsewhere on those categories?
Example below:
Thanks,
gokermu
(Mucahit Bilal GOKER)
18 August 2023 18:48
2
Hey @bmc ,
I took a quick look and looks like we don’t send that information for curtain walls. We appreciate you bringing this to our attention and we’ll do our best to fix the issue as soon as possible.
Thank you for taking the time to report this, it helps a lot🤗!
3 Likes
bmc
19 August 2023 10:44
3
Thanks @gokermu happy to help, FYI it is not just curtain wall, there are other categories missing,
Regards,
gokermu
(Mucahit Bilal GOKER)
19 August 2023 15:12
4
I wasn’t aware of that. Please feel free to share any other categories you have in mind.
teocomi
(Matteo Cominetti)
21 August 2023 05:42
5
FYI, this is being already resolved as part of this PR , and will be included in 2.16.
1 Like
bmc
21 August 2023 17:32
6
Great that is being updated, thanks for that,
@gokermu the other identified categories are:
Conduits
Ducts
Duct Fittings
Duct Insulations
Flex Ducts
Flex Pipes
Electrical Equipments
Electrical Fixtures
Entourage
Mechanical Equipment
Pads
Pipes
Pipe Insulations
Plumbing Fixtures
Planting
Railings-placed on stairs
Roof-Curtain panel/rooflights
Structural Beam Systems
Topography
Walls-Curtain Walls
Structural Trusses
2 Likes
gokermu
(Mucahit Bilal GOKER)
22 August 2023 05:37
7
Hey @bmc ,
Thank you so much for giving us the list of categories! We really appreciate it. We’ll go through it and keep you posted on our progress.
teocomi
(Matteo Cominetti)
22 August 2023 08:23
8
We’ve actually updated the logic, so it’s no longer an hard-coded list of categories, but all the ones of type Model, Internal and AnalyticalModel will now be sent. Change coming in 2.16!
1 Like
bmc
25 August 2023 13:56
9
Sounds good! Thanks for the updates. Any timeframe should we expect the 2.16?
jonathon
(Jonathon)
25 August 2023 14:20
10
1 Like
teocomi
(Matteo Cominetti)
28 August 2023 17:03
11
Yup, first release candidate is scheduled for end of this week, and stable in 2-3 weeks from now.
1 Like
gokermu
(Mucahit Bilal GOKER)
2 October 2023 10:32
12
Hey @bmc ,
We recently published the release candidate for 2.16. Install it using Manager and let us know what you think.
bmc
2 October 2023 10:55
13
Hi, I tried the RC1 and now RC3 and it is still no luck from me . It does not connect the account to the RVT connector, see post here: Revit Connector 2.16RC unable to connect to accounts or streams - Help - Speckle Community
I tried removing the connector and installing back in, tried removing account and log back.
Please let me know if you believe it could be something from my end I could try.
Thanks,
bmc
10 November 2023 16:45
14
Hi, just wanted to give you an update. The V2.16.3 now connect and works fine, and has resolved most of the missing categories mentioned above. But I noticed the some yet miss it as follows:
Entourage
Pads
Railings
Top Rails
Topography
Kind Regards,
jonathon
(Jonathon)
11 November 2023 10:25
15
Release 2.17 is being internally tested this week. It includes this change:
specklesystems:dev
← specklesystems:revit/connor/material-quantites-add-by-mesh
opened 04:37PM - 08 Nov 23 UTC
<!---
Provide a short summary in the Title above. Examples of good PR titles:…
* "Feature: adds metrics to component"
* "Fix: resolves duplication in comment thread"
* "Update: apollo v2.34.0"
-->
## Description & motivation
Solves issue https://github.com/specklesystems/speckle-sharp/issues/2117 and improves the calculation of material quantities.
There are some problems with obtaining quantities in Revit:
RevitAPI GetMaterialIds does not return all materials
Computation of area not clear
Some categories need further evaluation
<!---
Describe your changes, and why you're making them. What benefit will this have to others?
Is this linked to an open Github issue, a thread in Speckle community,
or another pull request? Link it here.
If it is related to a Github issue, and resolves it, please link to the issue number, e.g.:
Fixes #85, Fixes #22, Fixes username/repo#123
Connects #123
-->
## Changes:
- Defines a few routes to retrieve material quantities
- If the API GetMaterialArea call will return the area of a single face (instead of all faces), then it will use that method
- If the element is a duct or pipe, then the material values can be found on the MEP system
- Otherwise try to get the material and the area/volume from the element's mesh.
<!---
- Item 1
- Item 2
-->
## Checklist:
<!---
This checklist is mostly useful as a reminder of small things that can easily be
forgotten – it is meant as a helpful tool rather than hoops to jump through.
Put an `x` between the square brackets, e.g. [x], for all the items that apply,
make notes next to any that haven't been addressed, and remove any items that are not relevant to this PR.
-->
- [x] My pull request follows the guidelines in the [Contributing guide](https://github.com/specklesystems/speckle-server/blob/main/CONTRIBUTING.md)?
- [x] My pull request does not duplicate any other open [Pull Requests](../../pulls) for the same update/change?
- [x] My commits are related to the pull request and do not amend unrelated code or documentation.
- [x] My code follows a similar style to existing code.
- [ ] I have added appropriate tests.
- [ ] I have updated or added relevant documentation.
## References
Child of this PR https://github.com/specklesystems/speckle-sharp/pull/2715
<!---
(Optional -- remove this section if not needed )
Include **important** links regarding the implementation of this PR.
This usually includes a RFC or an aggregation of issues and/or individual conversations
that helped put this solution together. This helps ensure we retain and share knowledge
regarding the implementation, and may help others understand motivation and design decisions etc..
-->
which in turn incorporated a lot from:
specklesystems:dev
← ks-cph:dev-materialquantities
opened 08:01AM - 30 Jun 23 UTC
<!---
Provide a short summary in the Title above. Examples of good PR titles:…
* "Feature: adds metrics to component"
* "Fix: resolves duplication in comment thread"
* "Update: apollo v2.34.0"
-->
## Description & motivation
Solves issue #2117 and improves the calculation of material quantities.
There are some problems with obtaining quantities in Revit:
1. RevitAPI GetMaterialIds does not return all materials
2. Computation of area not clear
3. Some categories need further evaluation
## Changes:
- `Objects/Converters/ConverterRevit/ConverterRevitShared/ConversionUtils.cs` get the revit material from MEP elements
- `Objects/Converters/ConverterRevit/ConverterRevitShared/Partial Classes/ConvertMaterialQuantities.cs` get materials for `MEPCurves` and compute the quantities based on the geometry
- `Objects/Converters/ConverterRevit/ConverterRevitShared/Partial Classes/ConvertMaterialQuantities.cs` compute the quantities based on the geometry instead of the Revit API default methods. This is currently only implemented for windows, doors, and railings, but other categories may follow.
- `Objects/Converters/ConverterRevit/ConverterRevitShared/Partial Classes/ConvertMaterialQuantities.cs` compute the length of railings using the path length
- `Objects/Converters/ConverterRevit/ConverterRevitShared/Partial Classes/ConvertMaterialQuantities.cs` the new method GetGeometry is based on existing code
https://github.com/specklesystems/speckle-sharp/blob/15f0a8c516b19ae86a6777bd68fcafb2a9ebf29a/Objects/Converters/ConverterRevit/ConverterRevitShared/Partial%20Classes/ConvertMeshUtils.cs#L41-78
## Validation of changes:
The changes have been tested extensively with the default Revit model.
- for `MEPCurves`: Pipse, ducts
- for railings
- windows, doors
## Checklist:
<!---
This checklist is mostly useful as a reminder of small things that can easily be
forgotten – it is meant as a helpful tool rather than hoops to jump through.
Put an `x` between the square brackets, e.g. [x], for all the items that apply,
make notes next to any that haven't been addressed, and remove any items that are not relevant to this PR.
-->
- [x] My pull request follows the guidelines in the [Contributing guide](https://github.com/specklesystems/speckle-server/blob/main/CONTRIBUTING.md)?
- [x] My pull request does not duplicate any other open [Pull Requests](../../pulls) for the same update/change?
- [x] My commits are related to the pull request and do not amend unrelated code or documentation.
- [x] My code follows a similar style to existing code.
- [ ] I have added appropriate tests.
- [ ] I have updated or added relevant documentation.
Which is a set of workarounds in the Revit API for which certain material values are not returned straightforwardly. It incorporates a great deal of work by our friends at Gaiup for which we are thankful.
I cannot say that all of your list will be covered; while I know that Railings were and some fixes for other categories end up coming for “free” I suspect that Entourage hasn’t been a target for inspection. We can test against this list and report back when 2.17 release notes are available.
bmc
13 November 2023 08:10
16
Thanks for the updates jonathon