Azure AD Strategy for v2

Features & Ideas
1

Hi. Just wondering if anyone is working on adding an Azure AD authentication strategy to v2?

Happy to pick up where someone else has left off.

1 Like
2

Hi @peter.grainger, welcome to the forum! (better place than slack). The last I’ve heard from @sbreslav, he sent me a link to his fork right here.

I actually managed to finally get an Azure account this week, so I’ll be able to test it up and merge it if you’re going start hacking on it!

1 Like
3

Thanks for the link. It’s seems pretty straight forward so I’ll create a PR and you can check if you’re happy with the naming etc.

1 Like
4

Hi @peter.grainger @dimitrie, just a warning, I wasn’t actually able to get the version that uses passport-azure-ad lib to work. Not sure why, just didn’t have much time to debug, sorry about that. But I did get passport-azure-ad-oauth2 library to work, here is the link to that: speckle-server/azure.js at ad2-auth-provider · trax-gd/speckle-server · GitHub

The downside of passport-azure-ad-oauth2 lib is that it hasn’t been updated in a long while…

1 Like
5

Thanks @sbreslav loads of help.

1 Like
6

@sbreslav @dimitrie here is my first go feat(auth): 🙈 Add Azure AD auth option by peterjgrainger · Pull Request #204 · specklesystems/speckle-server · GitHub Let me know if the logic looks OK?

2 Likes
7

Sweet, it’s merged in now - and you should have gotten the nice golden contributor brick :sunglasses:

3 Likes